Remove require 'rspec/autorun' from the generated spec_helper.rb in 2.99 and 3.0.0
#855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alindeman
added a commit
that referenced
this pull request
Nov 22, 2013
|
@myronmarston, does this look OK? There's no reason to keep |
alindeman
added a commit
that referenced
this pull request
Nov 22, 2013
|
LGTM, I think we decided that anyone wanting that functionality can do so themselves... |
|
Cool, I need to add a Changelog entry. I'll merge soon unless there are objections. |
|
Yep, FWIW, there's a lot more I want to do with the generated |
|
This seems a positive change. 👍 to merge if you're ready, @alindeman |
JonRowe
added a commit
that referenced
this pull request
Dec 5, 2013
Remove `require 'rspec/autorun'` from the generated spec_helper.rb in 2.99 and 3.0.0
JonRowe
added a commit
that referenced
this pull request
Dec 8, 2013
Remove `require 'rspec/autorun'` from the generated spec_helper.rb in 2.99 and 3.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.