This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Add in_sub_process_where_possible
#178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @myronmarston |
|
I think I'd prefer this was called LGTM otherwise. |
For specs where we care about not poisoning our environment it'd be good to run them in a subprocess, but these specs may be too important to skip on platforms without fork, so we can just run normally instead.
JonRowe
force-pushed
the
in_sub_process_where_possible
branch
from
19ed6de to
805422b
Compare
|
Changed, always up for shorter ;) |
|
LGTM |
JonRowe
added a commit
that referenced
this pull request
Feb 10, 2015
Add `in_sub_process_where_possible`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For specs where we care about not poisoning our environment it'd be good to run
them in a subprocess, but these specs may be too important to skip on
platforms without fork, so we can just run normally instead.