This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Expose wether exception cause is supported #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samphippen care to give this a once over? |
| @@ -55,6 +55,18 @@ def caller_locations_supported? | |||
| respond_to?(:caller_locations, true) | |||
| end | |||
|
|
|||
| begin | |||
There was a problem hiding this comment.
What do you think about doing a respond_to? check here? I think that'd be a lot cleaner.
There was a problem hiding this comment.
I preferred not instantiating an exception...
There was a problem hiding this comment.
oh, right, Exception.instance_methods.include?(:cause)?
There was a problem hiding this comment.
Exception.method_defined?(:cause)
No need for a linear include? operation.
JonRowe
force-pushed
the
exception_cause_supported
branch
2 times, most recently
from
9d42426 to
c1c5381
Compare
|
Hmm randomly this is failing on windows but it's for an unrelated encoding spec.. |
JonRowe
force-pushed
the
exception_cause_supported
branch
from
c1c5381 to
867a144
Compare
myronmarston
added a commit
that referenced
this pull request
Oct 1, 2015
Expose wether exception cause is supported
|
LGTM. Merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changelog because this is an internal feature