This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Skip encoding spec on windows #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
force-pushed
the
windows_encoding
branch
2 times, most recently
from
4ec7279 to
6959731
Compare
JonRowe
force-pushed
the
windows_encoding
branch
from
6959731 to
a895aa4
Compare
JonRowe
changed the title
|
Anyone have any objection to this @rspec/rspec? Just seems to be flakey and I don't have the time to debug windows... |
soulcutter
added a commit
that referenced
this pull request
Sep 30, 2015
Skip encoding spec on windows
|
Seems reasonable to me. |
|
@JonRowe can you ping me on EncodedString stuff like this? I'll look into it (at some point :) |
|
You're welcome to look into the windows failure now if you like ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.