This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Upgrade rubocop, motivated by CVE. #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myronmarston
approved these changes
Jan 2, 2018
.rubocop.yml
Outdated
|
|
||
| Lint/AssignmentInCondition: | ||
| Exclude: | ||
| # The pattern makes sense where |
There was a problem hiding this comment.
I don't understand this comment. Looks like you intended to write more after "where"?
| @@ -147,7 +146,6 @@ def supports_rebinding_module_methods? | |||
| false | |||
| end | |||
| end | |||
| # rubocop:enable Lint/Eval | |||
There was a problem hiding this comment.
Does rubocop no longer support this way of disabling checks? Or do you just prefer putting the exception in the config file?
There was a problem hiding this comment.
it does, but it was redundant here
xaviershay
force-pushed
the
upgrade-rubocop
branch
from
b76ee94 to
4e51458
Compare
xaviershay
force-pushed
the
upgrade-rubocop
branch
from
4e51458 to
5490260
Compare
|
Current build failure: timeout on jruby 1.7. Retried it. |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaulted most new things to off, though tried to keep performance and linters.
Note that
.rubocop_rspec_basedoesn't 100% match up withrspec-devbecause I was adding to it as we went along. Once these are all merged I'm planning to ensure they're all consistent.