Add fork_supported?.
#342
Add fork_supported?.
#342
Conversation
This is needed for the new fork-based bisect runner in rspec/rspec-core#2511.
|
Can I get a review of this, @rspec/rspec ? I tried to target the Gemfile in rspec/rspec-core#2511 at this branch so I can use this change there but it's not working for some reason. Merging this is the simplest path forward. |
| false | ||
| end | ||
| else | ||
| def fork_supported? |
There was a problem hiding this comment.
Could we define this conditionally or memoized to avoid calling Process.respond_to?(:fork) repeatedly?
There was a problem hiding this comment.
I'd want a benchmark showing memoization is faster as Process.respond_to?(:fork) isn't something I'd expect to be slow. Re: defining it conditionally...we could, but that's not an approach we're consistently following in this file. If we want to go that route, I think we should do it consistently throughout this file.
This method is only going to be called once per spec run (in RSpec::Core::Configuration#initialize) so it's definitely not a perf hot spot, anyway.
This is needed for the new fork-based bisect runner
in rspec/rspec-core#2511.