This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Adapt JRuby arity workaround to BlockSignature #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
reviewed
Mar 12, 2018
| @@ -186,7 +186,7 @@ class MethodSignature < remove_const(:MethodSignature) | |||
|
|
|||
| def classify_parameters | |||
| super | |||
| return unless @method.arity == -1 && @method.owner.respond_to?(:java_class) | |||
| return unless @method.arity == -1 && @method.respond_to?(:owner) && @method.owner.respond_to?(:java_class) | |||
There was a problem hiding this comment.
Rather than specs then, can we get a note about why this is necessary?
There was a problem hiding this comment.
Line needs to be broken up to pass the build now :)
The workaround looking up the corresponding Java class and looking at its methods only works for methods, and doesn't work for Proc, where there isn't a direct API to access the proxied Java class. While the same problem exists for Proc's, until jruby/jruby#2817 has been resolved, there isn't much that can be done for that case. However, the current code fails to run for all blocks with arity -1, so this tweak is necessary to ensure normal blocks work again. I couldn't find any specs for BlockSignature, so wasn't sure where it would be appropriate to add a test for this.
grddev
force-pushed
the
adapt-jruby-workaround-to-blocks
branch
from
ffcae07 to
07be559
Compare
|
Thanks @grddev! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workaround looking up the corresponding Java class and looking at its methods only works for methods, and doesn't work for Proc, where there isn't a direct API to access the proxied Java class.
While the same problem exists for Proc's, until jruby/jruby#2817 has been resolved, there isn't much that can be done for that case. However, the current code fails to run for all blocks with arity -1, so this tweak is necessary to ensure normal blocks work again.
I couldn't find any specs for BlockSignature, so wasn't sure where it would be appropriate to add a test for this.