Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Updates from rspec-dev (2018-12-25) #360

Merged
merged 2 commits into from
Dec 30, 2018

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Dec 25, 2018

These are some updates, generated from rspec-dev's rake tasks.

@JonRowe
Copy link
Member Author

JonRowe commented Dec 26, 2018

@yujinakayama do my changes make sense? Has Ruby 2.6.0 changed how the expected output?

Copy link
Member

@benoittgt benoittgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @JonRowe for the job. LGTM. Sorry for the delay.

@yujinakayama
Copy link
Member

I'm not sure about the new @period AST node from Ripper, but it's OK as long as RSpec::Core::Formatters::SnippetExtractor and RSpec::Expectations::BlockSnippetExtractor are working on Ruby 2.6.

@JonRowe JonRowe merged commit a53114f into master Dec 30, 2018
@JonRowe JonRowe deleted the update-travis-build-scripts-2018-12-25-for-master branch December 30, 2018 15:01
JonRowe added a commit that referenced this pull request Mar 3, 2019
…2-25-for-master

Updates from rspec-dev (2018-12-25)
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 6, 2021
…e-travis-build-scripts-2018-12-25-for-master

Updates from rspec-dev (2018-12-25)

---
This commit was imported from rspec/rspec-support@d2c93fd.
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 6, 2021
…e-travis-build-scripts-2018-12-25-for-master

Updates from rspec-dev (2018-12-25)

---
This commit was imported from rspec/rspec-support@d2c93fd.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants