This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Empty last hash matches allow any kwargs #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, you'll need a spec for this, also consider not everything responds to |
|
@JonRowe At that point args.last is guaranteed to be a Hash so it is guaranteed to respond to |
|
@JonRowe - Just a friendly ping |
|
Sorry for the late review. This patch looks good to me. Because we do For the failing on appveyor. It is unrelated. https://ci.appveyor.com/project/rspec/rspec-support/builds/23996036/job/egb1o129jo145r0t |
benoittgt
approved these changes
Apr 30, 2019
|
Thanks :) |
JonRowe
added a commit
that referenced
this pull request
Jun 10, 2019
Empty last hash matches allow any kwargs
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…low_all_kwargs Empty last hash matches allow any kwargs --- This commit was imported from rspec/rspec-support@7c2aef3.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…low_all_kwargs Empty last hash matches allow any kwargs --- This commit was imported from rspec/rspec-support@7c2aef3.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #374