Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Check for nil instead of truthiness when making a diff #377

Merged
merged 1 commit into from
Jun 8, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rspec/support/differ.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class Differ
def diff(actual, expected)
diff = ""

if actual && expected
unless actual.nil? || expected.nil?
if all_strings?(actual, expected)
if any_multiline_strings?(actual, expected)
diff = diff_as_string(coerce_to_string(actual), coerce_to_string(expected))
Expand Down
7 changes: 7 additions & 0 deletions spec/rspec/support/differ_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,13 @@ def inspect; "<BrokenObject>"; end
expect(diff).to be_diffed_as(expected_diff)
end
end

context 'when expected or actual is false' do
it 'generates a diff' do
expect(differ.diff(true, false)).to_not be_empty
expect(differ.diff(false, true)).to_not be_empty
end
end
end
end
end
Expand Down