Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Allow File.read to be stubbed out without breaking ripper support #431

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Sep 28, 2020

Following on from conversation in rspec/rspec-mocks#1341 this fixes issues like #428 when File.read is stubbed out and returns non standard content.

Copy link
Member

@benoittgt benoittgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Jon

Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this works nicely. Thanks!

@pirj pirj merged commit 327852f into main Sep 28, 2020
@pirj pirj deleted the fix-file-read-stub branch September 28, 2020 14:06
JonRowe pushed a commit that referenced this pull request Oct 23, 2020
Allow File.read to be stubbed out without breaking ripper support
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 6, 2021
…ile-read-stub

Allow File.read to be stubbed out without breaking ripper support

---
This commit was imported from rspec/rspec-support@bccb1b7.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants