Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Updates from rspec-dev (2020-11-21) #440

Merged
merged 5 commits into from
Nov 21, 2020

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Nov 21, 2020

These are some updates, generated from rspec-dev's rake tasks.

@JonRowe JonRowe force-pushed the update-ci-build-scripts-2020-11-21-for-main branch 5 times, most recently from 2e37b53 to be25cb7 Compare November 21, 2020 12:31
@JonRowe JonRowe force-pushed the update-ci-build-scripts-2020-11-21-for-main branch 7 times, most recently from 62abb69 to ee6e060 Compare November 21, 2020 14:17
@JonRowe JonRowe force-pushed the update-ci-build-scripts-2020-11-21-for-main branch from ee6e060 to bee102a Compare November 21, 2020 14:20
@JonRowe JonRowe force-pushed the update-ci-build-scripts-2020-11-21-for-main branch from bee102a to 9761ca4 Compare November 21, 2020 14:24
@JonRowe JonRowe merged commit bd26f12 into main Nov 21, 2020
@JonRowe JonRowe deleted the update-ci-build-scripts-2020-11-21-for-main branch November 21, 2020 14:43
@pirj
Copy link
Member

pirj commented Nov 21, 2020

Ripper is supported on 9.1.17.0 according to test suite

👍 Good to know. I indeed to remove one more method from RubyFeatures in drop-old-rubies.

@JonRowe
Copy link
Member Author

JonRowe commented Nov 21, 2020

ripper_supported? is not a method that should be removed.

@pirj
Copy link
Member

pirj commented Nov 21, 2020

@JonRowe, do you mind to elaborate why, to support JRuby 9.1?

@JonRowe
Copy link
Member Author

JonRowe commented Nov 21, 2020

Because we need it to flag ripper support on Rubies that don't. This includes JRuby 9.1 below 17, and Rubinius.

@pirj
Copy link
Member

pirj commented Nov 21, 2020

Right, Rubinius slipped my mind completely 👍
I had an impression that there's a jruby? check when defining ripper_supported? in drop-old-rubies, but .rbx? is the only one.

JonRowe added a commit that referenced this pull request Dec 27, 2020
…-for-main

Updates from rspec-dev (2020-11-21)
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 6, 2021
…e-ci-build-scripts-2020-11-21-for-main

Updates from rspec-dev (2020-11-21)

---
This commit was imported from rspec/rspec-support@bd26f12.
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 6, 2021
…e-ci-build-scripts-2020-11-21-for-main

Updates from rspec-dev (2020-11-21)

---
This commit was imported from rspec/rspec-support@a8e609d.
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 19, 2021
…e-ci-build-scripts-2020-11-21-for-main

Updates from rspec-dev (2020-11-21)

---
This commit was imported from rspec/rspec-support@bd26f12.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants