Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Updates from rspec-dev (2020-12-08) #445

Merged
merged 2 commits into from
Dec 8, 2020

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Dec 8, 2020

These are some updates, generated from rspec-dev's rake tasks.

@pirj
Copy link
Member

pirj commented Dec 8, 2020

It's beyond my understanding how this passes when .travis.yml is removed, but this line is still in place:

bundle_install_flags=`cat .travis.yml | grep bundler_args | tr -d '"' | grep -o " .*"`

Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! 💯

@JonRowe
Copy link
Member Author

JonRowe commented Dec 8, 2020

It's beyond my understanding how this passes when .travis.yml is removed, but this line is still in place:

bundle_install_flags=`cat .travis.yml | grep bundler_args | tr -d '"' | grep -o " .*"`

It's empty when it fails, and bundle has already happened in github actions, so it presumedly has the config from that cached. This can be cleaned up at a later (post 4.0.0 merge to master) date.

@JonRowe JonRowe merged commit d81dd64 into 4-0-dev Dec 8, 2020
@JonRowe JonRowe deleted the update-ci-build-scripts-2020-12-08-for-4-0-dev branch December 8, 2020 10:29
@JonRowe
Copy link
Member Author

JonRowe commented Dec 8, 2020

This can be cleaned up at a later (post 4.0.0 merge to master) date.

Or applied to both I guess, just it need not be a 4.0.0 specific change

@pirj
Copy link
Member

pirj commented Dec 8, 2020

It's empty when it fails

I guess we don't set set -e, so this subshell call doesn't fail the caller if it fails itself, and we just go on.
👍

yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 19, 2021
…e-ci-build-scripts-2020-12-08-for-4-0-dev

Updates from rspec-dev (2020-12-08)

---
This commit was imported from rspec/rspec-support@d81dd64.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants