This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Fix simplecov source file filter #481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplecov 0.20.0 does filtering with abosulute file paths. We were not excluding `bundle` directory. Before (https://github.com/rspec/rspec-support/runs/1627962469) ``` Coverage report generated for RSpec to /home/runner/work/rspec-support/rspec-support/coverage. 956 / 1444 LOC (66.2%) covered. Coverage report generated for RSpec to /home/runner/work/rspec-support/rspec-expectations/coverage. 3116 / 3596 LOC (86.65%) covered. ``` After (https://github.com/rspec/rspec-support/pull/480/checks?check_run_id=1628102829) ``` Coverage report generated for RSpec to /home/runner/work/rspec-support/rspec-support/coverage. 519 / 544 LOC (95.4%) covered. Coverage report generated for RSpec to /home/runner/work/rspec-support/rspec-expectations/coverage. 2767 / 2797 LOC (98.93%) covered. ``` Debug output, excerpt from `coverage/index.html` (https://github.com/rspec/rspec-expectations/pull/1273/checks?check_run_id=1628049675): ``` <td class="strong t-file__name">...bundle/ruby/2.7.0/gems/diff-lcs-1.4.4/lib/diff/lcs.rb">bundle/ruby/2.7.0/gems/diff-lcs-1.4.4/lib/diff/lcs.rb ...</td> <td class="red strong cell--number t-file__coverage">33.08 %</td> ```
|
@JonRowe This fixes red builds across the board. rspec/rspec-dev#279 and sub-prs can be merged after this one. rspec/rspec-dev#280 can be merged after #482. |
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 19, 2021
…implecov-source-file-filter Fix simplecov source file filter --- This commit was imported from rspec/rspec-support@5a6c9aa.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplecov 0.20.0 does filtering with abosulute file paths.
We were not excluding
bundledirectory.Before (https://github.com/rspec/rspec-support/runs/1627962469)
After
(https://github.com/rspec/rspec-support/pull/480/checks?check_run_id=1628102829)
Debug output, excerpt from
coverage/index.html(https://github.com/rspec/rspec-expectations/pull/1273/checks?check_run_id=1628049675):
rspec-corealready does filtering this way https://github.com/rspec/rspec-core/blob/fe3084758857f0714f05ada44a18f1dfe9bf7a7e/script/rspec_with_simplecov#L31