This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Support end-less methods in Source::Token #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yujinakayama
force-pushed
the
support-end-less-methods-in-snippet-extractor
branch
from
04be69a to
633dc3d
Compare
|
@JonRowe ping |
yujinakayama
deleted the
support-end-less-methods-in-snippet-extractor
branch
|
Thanks for this, it's been hidden on a todo list for ages as I wanted some local tests for it but I agree it can be merged and those added later as I'm so behind on it. |
yujinakayama
added a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 26, 2021
This commit was imported from rspec/rspec-support@61a6f4f.
yujinakayama
added a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 26, 2021
…rt-end-less-methods-in-snippet-extractor Support end-less methods in Source::Token --- This commit was imported from rspec/rspec-support@2a17194.
JonRowe
pushed a commit
that referenced
this pull request
Nov 3, 2021
…t-extractor Support end-less methods in Source::Token
JonRowe
pushed a commit
that referenced
this pull request
Nov 3, 2021
…t-extractor Support end-less methods in Source::Token
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes rspec/rspec-core#2892.