This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Move in code from RSpec::Mocks::RecursiveConstantMethods #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myronmarston
added a commit
that referenced
this pull request
Jun 6, 2014
Move in code from RSpec::Mocks::RecursiveConstantMethods
|
Merged. Thanks! |
myronmarston
added a commit
that referenced
this pull request
Jun 6, 2014
This was included in #76 but is not actually needed since .rspec includes an option to require spec_helper.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in rspec/rspec-core#1580, transferring the
RecursiveConstantMethodsmodule to this gem so it can be used by rspec-core to safely look up constants without checking ancestor objects.I also added specs for the module since it was only tested indirectly through the the constant mutation examples in rspec-mocks.