Avoid string comparison for QueryBuilderGroup identification #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported by @ucuncuatabek [[1]](#61 (comment)) and @janhorubala [[2]](dabernathy89/vue-query-builder#70 (comment)), this is an attempt to fix odd drag'n'drop behaviour with production builds.
Code Coverage ReportCoverage after merging fix-merge-trap-comparison into main
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||
1 similar comment
Code Coverage ReportCoverage after merging fix-merge-trap-comparison into main
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||
Code Coverage ReportCoverage after merging fix-merge-trap-comparison into main
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||
|
@janhorubala and @ucuncuatabek, kindly asking you to verify if this patch fixes the issue you encounter in the mentioned links above. For some reason I don't understand, I've never been able to reproduce what the bug, but it seems to me, the webpack's terser plugin, used for the production build, mangels the Please don't forget to |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @ucuncuatabek [1] and @janhorubala [2], this is an attempt to fix odd drag'n'drop behaviour with production builds.