[CI] Add OpenLDAP integration tests #129
Conversation
|
|
||
| if !INTEGRATION | ||
| puts "Skipping integration tests..." | ||
| else |
There was a problem hiding this comment.
👍 for skipping these for local development. If we end up splitting these in multiple files, it might be nice to have a IntegrationTest base class to do this conditional.
Use an abstract integration test case.
|
Removed the separate Also added a Vagrant VM definition to run the OpenLDAP integration environment locally. Includes instructions on how to run integration tests locally with it. Think this is good enough for now. We'll definitely want to expand on integration tests, but I think we'd be better served doing that as we continue to refactor internals. |
| @@ -0,0 +1,30 @@ | |||
| # Local OpenLDAP Integration Testing | |||
|
|
|||
| Set up a VM to run integration tests against OpenLDAP locally. | |||
There was a problem hiding this comment.
Maybe add a link here to http://www.vagrantup.com
|
Great start. 🚢 after that last comment about linking to vagrant docs. |
[CI] Add OpenLDAP integration tests
[CI] Add OpenLDAP integration tests
This PR sets up an additional set of test environments that installs OpenLDAP and runs special integration tests that connects against that OpenLDAP server.
This was based off of similar work in github/github-ldap: github/github-ldap#48.
Will flesh out the integration tests today, still more to come.
cc @jch @schaary