Skip to content

Update test suite for JRuby 9.2 #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ rvm:
- 2.5
- 2.6
- 2.7
- jruby-9.2
# optional
- ruby-head
- jruby-19mode
Expand Down
2 changes: 1 addition & 1 deletion net-ldap.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,5 @@ the most recent LDAP RFCs (4510-4519, plutions of 4520-4532).}
s.add_development_dependency("rake", "~> 10.0")
s.add_development_dependency("rubocop", "~> 0.49.0")
s.add_development_dependency("test-unit")
s.add_development_dependency("byebug")
s.add_development_dependency("byebug") unless RUBY_PLATFORM == "java"
end
2 changes: 1 addition & 1 deletion test/test_ldap.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
require 'test_helper'
require_relative 'test_helper'

class TestLDAPInstrumentation < Test::Unit::TestCase
# Fake Net::LDAP::Connection for testing
Expand Down
6 changes: 6 additions & 0 deletions test/test_ssl_ber.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,16 @@ def setup
end

def test_transmit_strings
omit "JRuby throws an error without a real socket"
omit_if RUBY_PLATFORM == "java"

assert_equal "foo", transmit("foo")
end

def test_transmit_ber_encoded_numbers
omit "JRuby throws an error without a real socket"
omit_if RUBY_PLATFORM == "java"

@to.write 1234.to_ber
assert_equal 1234, @from.read_ber
end
Expand Down