Skip to content

Use the actual JRUBY_REVISION in release note #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2025
Merged

Use the actual JRUBY_REVISION in release note #8

merged 3 commits into from
Feb 24, 2025

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented Feb 18, 2025

Currently the github release note has the "latest commit" of jruby, however, it's not always the same commit of the latest maven snapshot due to the schedule of jruby nightly builds.

For example, I was downloading a build from https://github.com/ruby/jruby-dev-builder/releases/tag/v20250218.190130 - The release note says v20250218.190130 has jruby 00021bc2d8067eb2b7478352a7883b70b9069246, but in reality it was f1f9396cd79bb66b79217ce6e3c894ae5a59934d.

This PR fix the release note by actually checking the JRUBY_REVISION on the downloaded jruby maven snapshot, and then set that as the release note.

@ntkme ntkme requested a review from eregon February 19, 2025 01:30
@ntkme
Copy link
Contributor Author

ntkme commented Feb 19, 2025

Did some refactoring:

  • Change the release note to jruby/jruby@${commit} ${maven_download_url}, and run uniqueness check against the download url instead of commit.
  • Remove unused code.
  • Cache nokogiri gem with setup-ruby.

Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!

I'm not sure it's worth caching the install of nokogiri since it's precompiled these days, but it seems fine (a bit more complexity with moving the test Gemfile).

@eregon eregon merged commit f7f54e3 into ruby:master Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants