Gas simplification for Csstore, named rules #1560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…check for foundry
…as for simplifying infinite gas query
tothtamas28
approved these changes
Feb 13, 2023
PetarMax
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls out several components of which can get merged standalone: #1538
Csstorethat is fairly simple (and failing tests). These missing simplifications were causing lots of unnecessary branches when doing foundry proofs without infinite gas.kevm-pyk.--debugoption frombin/kevmtokevm-pyk.00is produced for Foundry proofs.This change makes it so that none of the proofs in the KEVM foundry test-suite are breaking every opcode due to out-of-gas errors (which makes them significantly faster). Now all the basic blocks that are found in that proof suite are actually due to control-flow branches, and reaching the 1000 step max-depth limit.