Refactor reachability proof strategies #1932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would like to use the same terminology as the domain experts, which is "check implication".
The ProofState associated type family is always instantiated at the concrete ProofState type, so this was a meaningless layer of indirection.
The associated type family Prim was only ever instantiated at a single type.
The function checkImplication returns a CheckImplicationResult instead of a ProofState. This follows a principle from domain-driven design: the function indicates its own result (CheckImplicationResult) instead of telling the caller what to do next (ProofState). The code is more flexible because checkImplication now does not need to know anything about the caller.
ttuegel
force-pushed
the
issue-1665--refactor
branch
from
776c91d to
2abc638
Compare
This acts to separate the domain model from the application code.
This change extracts application code from the domain model.
Now, the only instance of transitionRule is the canonical instance. This instance _defines_ reachability proving and the individual types of reachability claims may only define how they implement each step.
This change reinforces the separation between the application and domain model code.
This makes the one-path strategy like the all-path strategy.
The strategy belongs to and is common to all reachability proofs.
ttuegel
force-pushed
the
issue-1665--refactor
branch
from
d247113 to
d63d128
Compare
ana-pantilie
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer checklist
stack test --coveragestack haddock