kore-repl: do not remove direct children of branchings when using clear command #1952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttuegel
approved these changes
Jul 8, 2020
kore/src/Kore/Repl/Interpreter.hs
Outdated
| | unReplNode node == 0 -> | ||
| putStrLn' "Cannot clear initial node (0)." | ||
| | isDirectDescendentOfBranching node graph -> | ||
| putStrLn' "Cannot clear a direct descendent of a branching node." |
There was a problem hiding this comment.
Suggested change
| putStrLn' "Cannot clear a direct descendent of a branching node." | |
| putStrLn' "Cannot clear a direct descendant of a branching node." |
Can we also add a note to the help text for this command, which explains that this would make the proof invalid?
…e/kore into bug-do-not-remove-branchings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer checklist
stack test --coveragestack haddock