Do not ignore --strategy all

[andreiburdusa]

---

Fixes #2205

Reviewer checklist

• Test coverage: stack test --coverage
• Public API documentation: stack haddock

[MirceaS]

all looks in order to me but let's wait for Ana's review as well

[ttuegel]

We need to gather the branches here, and remove Logic.observeAllT in takeExitCode, below. Otherwise, we would return ExitFailure 111 when all the branches agree, if any branch would return \bottom.

Suggested change

	exitCodePatterns <- do
	pat <- Logic.scatter $ fmap mkGetExitCode `MultiOr.map` finalConfig
	Pattern.simplifyTopConfiguration pat
	exitCodePatterns <-
	do
	pat <- Logic.scatter $ fmap mkGetExitCode `MultiOr.map` finalConfig
	Pattern.simplifyTopConfiguration pat
	& MultiOr.gather

[ttuegel]

We don't need nubOrd here if we use MultiOr.gather above:

Suggested change

	let exitList =
	extractExit . Pattern.term
	<$> Foldable.toList exitCodePatterns
	exitCode =
	case nubOrd exitList of
	[exit] -> exit
	_ -> ExitFailure 111
	let exitCode =
	case toList (MultiOr.map Pattern.term exitCodePatterns) of
	[exitTerm] -> extractExit exitTerm
	_ -> ExitFailure 111

[ttuegel]

I have some suggestions for clean-up, but this looks pretty good.

[ttuegel]

Because this type was changed, let's change the name of the argument to configs instead.

[ttuegel]

Suggested change

	exitCodePatterns <-
	do
	pat <- Logic.scatter $ fmap mkGetExitCode `MultiOr.map` finalConfig
	Pattern.simplifyTopConfiguration pat
	& MultiOr.gather
	let flatExitCodePatterns = MultiOr.flatten exitCodePatterns
	exitCode =
	case toList (MultiOr.map Pattern.term flatExitCodePatterns) of
	[exitTerm] -> extractExit exitTerm
	_ -> ExitFailure 111
	return exitCode
	exitCodePatterns <-
	do
	config <- Logic.scatter configs
	Pattern.simplifyTopConfiguration (mkGetExitCode <$> config)
	>>= Logic.scatter
	& MultiOr.gather
	let exitCode =
	case toList (MultiOr.map Pattern.term exitCodePatterns) of
	[exitTerm] -> extractExit exitTerm
	_ -> ExitFailure 111
	return exitCode

[andreiburdusa]

@ttuegel If I use gather :: (Ord a, TopBottom a, MonadLogic m) => m a -> m (MultiOr a) there, then the lambda function given to takeExitCode has to return a MonadLogic result. Then how can I change its signature to
takeExitCode :: (([Sort] -> Symbol) -> simplifier ExitCode)?

[ttuegel]

Sorry, I meant to suggest using MultiOr.observeAllT instead of MultiOr.gather.

[ttuegel]

There is an extra LogicT here:

Suggested change

	:: (([Sort] -> Symbol) -> LogicT simplifier ExitCode)
	:: (([Sort] -> Symbol) -> simplifier ExitCode)

[ttuegel]

Now this function is simply

    takeExitCode act =
        resolve "LblgetExitCode"
        & maybe (pure ExitSuccess) act