-
Notifications
You must be signed in to change notification settings - Fork 44
kore-parser: Make --no-print-definition and --no-print-pattern default and make --module and --pattern mandatory to go together #2273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e parser to False
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add unit tests, particularly to check that the combination --no-print-definition --print-definition
works. You will probably have to move enableDisableFlag
into the library.
I know that command-line parsing is my favorite example of low-value tests, but I'm starting to change my mind; it's obviously not simple to get command-line parsing right and the tests are easy to write.
Fixes #2264
Fixes #2254
Reviewer checklist
stack test --coverage
stack haddock