Skip to content

kore-parser: Make --no-print-definition and --no-print-pattern default and make --module and --pattern mandatory to go together #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Dec 2, 2020

Conversation

MirceaS
Copy link
Contributor

@MirceaS MirceaS commented Nov 17, 2020

Fixes #2264
Fixes #2254


Reviewer checklist
  • Test coverage: stack test --coverage
  • Public API documentation: stack haddock

Copy link
Contributor

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests, particularly to check that the combination --no-print-definition --print-definition works. You will probably have to move enableDisableFlag into the library.

I know that command-line parsing is my favorite example of low-value tests, but I'm starting to change my mind; it's obviously not simple to get command-line parsing right and the tests are easy to write.

@ttuegel ttuegel changed the title changed the dafault state of print-definition and print-pattern of the parser to False kore-parser: Make --no-print-definition and --no-print-pattern default Nov 17, 2020
@MirceaS MirceaS requested a review from ttuegel November 24, 2020 17:28
@ttuegel ttuegel self-requested a review December 2, 2020 15:27
@MirceaS MirceaS changed the title kore-parser: Make --no-print-definition and --no-print-pattern default kore-parser: Make --no-print-definition and --no-print-pattern default and make --module and --pattern mandatory to go together Dec 2, 2020
@rv-jenkins rv-jenkins merged commit bd765b7 into master Dec 2, 2020
@rv-jenkins rv-jenkins deleted the 2264 branch December 2, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants