-
Notifications
You must be signed in to change notification settings - Fork 44
Infer that terms are defined to send to SMT solver #2292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rv-jenkins
merged 17 commits into
runtimeverification:master
from
ana-pantilie:definedness-and-smt-solver
Dec 2, 2020
Merged
Infer that terms are defined to send to SMT solver #2292
rv-jenkins
merged 17 commits into
runtimeverification:master
from
ana-pantilie:definedness-and-smt-solver
Dec 2, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttuegel
reviewed
Nov 30, 2020
kore/src/Kore/Step/SMT/Evaluator.hs
Outdated
@@ -195,7 +194,7 @@ decidePredicate predicates = | |||
query :: MaybeT simplifier Result | |||
query = | |||
SMT.withSolver $ evalTranslator $ do | |||
tools <- Simplifier.askMetadataTools | |||
tools <- lift Simplifier.askMetadataTools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not move this outside SMT.withSolver
instead?
Co-authored-by: Thomas Tuegel <[email protected]>
ttuegel
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2287
empty
makes all new unit tests pass, though.Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.