Skip to content

Infer that terms are defined to send to SMT solver #2292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ana-pantilie
Copy link
Contributor

@ana-pantilie ana-pantilie commented Nov 26, 2020

Fixes #2287

  1. Can now declare symbols to be used when translating test data for the solver.
  2. Added unit tests as described in the issue. The first two tests had to be commented out, because of this issue. The other two should have only passed after these changes, but they used to pass before as well. Changing this to empty makes all new unit tests pass, though.
  3. Further changes should be described in the issue.

Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@@ -195,7 +194,7 @@ decidePredicate predicates =
query :: MaybeT simplifier Result
query =
SMT.withSolver $ evalTranslator $ do
tools <- Simplifier.askMetadataTools
tools <- lift Simplifier.askMetadataTools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not move this outside SMT.withSolver instead?

@ana-pantilie ana-pantilie marked this pull request as ready for review December 2, 2020 05:51
@ana-pantilie ana-pantilie requested a review from ttuegel December 2, 2020 05:51
@rv-jenkins rv-jenkins merged commit 3fd34f9 into runtimeverification:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infer that terms are defined to send to SMT solver
3 participants