Improve the performance of the Kore parser #2296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MirceaS
changed the title
space and stringParserToIdParser Lexer functions
Using Text instead of String reduces peak memory use by 43% and total allocation by 24%. Never use String.
MirceaS
commented
Dec 2, 2020
Comment on lines
+520
to
+522
| Text.readFile fileName | ||
| & liftIO | ||
| & clockSomethingIO "Reading the input file" |
There was a problem hiding this comment.
@ttuegel Why are these the other way round now?
There was a problem hiding this comment.
I changed it from ($) to (&) so that the action (Text.readFile) would appear before the wrappers.
ttuegel
changed the title
|
I made some changes to your parser performance pull request which reduce the memory use significantly. (For some reason we were still using String. Never use String.) I would like you to try a few more things:
|
ttuegel
suggested changes
Dec 9, 2020
Comment on lines
+520
to
+522
| Text.readFile fileName | ||
| & liftIO | ||
| & clockSomethingIO "Reading the input file" |
There was a problem hiding this comment.
I changed it from ($) to (&) so that the action (Text.readFile) would appear before the wrappers.
kore/src/Kore/Parser/Lexer.hs
Outdated
Comment on lines
228
to
230
| (genericId, _) <- Parser.match | ||
| $ (Parser.satisfy isFirstChar <?> "first identifier character") | ||
| >> Parser.takeWhileP (Just "identifier character") isBodyChar |
There was a problem hiding this comment.
I think this is easier to read:
Suggested change
| (genericId, _) <- Parser.match | |
| $ (Parser.satisfy isFirstChar <?> "first identifier character") | |
| >> Parser.takeWhileP (Just "identifier character") isBodyChar | |
| (genericId, _) <- Parser.match $ do | |
| _ <- Parser.satisfy isFirstChar <?> "first identifier character" | |
| _ <- Parser.takeWhileP (Just "identifier character") isBodyChar | |
| pure () |
kore/src/Kore/Parser/Lexer.hs
Outdated
| then do | ||
| skipChar '\\' | ||
| (c :) <$> parseIdRaw KeywordsPermitted | ||
| then fst <$> Parser.match |
There was a problem hiding this comment.
Using match here makes the look-ahead (above) redundant.
andreiburdusa
approved these changes
Dec 9, 2020
ttuegel
approved these changes
Dec 9, 2020
ttuegel
added a commit
that referenced
this pull request
Dec 10, 2020
* Inline some primitive parsers * Kore.Parser.Lexer: Remove unused primitive parsers * Run Parser over Text, not String Using Text instead of String reduces peak memory use by 43% and total allocation by 24%. Never use String. Co-authored-by: Thomas Tuegel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2189
Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.