Materialize Nix expressions #2301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local overrides ruin binary caching.
Materialization saves the part of the Nix expression which would be generated every time the project is built. This part tracks the package description and dependencies, so it only changes infrequently. Saving the output of this step (so that we can skip building it) makes the build faster. The drawback of this approach is that we must periodically run with checkMaterialization enabled to detect when the materialization needs to be updated.
The materialization check is moved into the Release workflow.
ttuegel
force-pushed
the
nix--materialize
branch
from
2927937 to
26459b4
Compare
ttuegel
added a commit
that referenced
this pull request
Dec 10, 2020
* Remove support for local overrides Local overrides ruin binary caching. * Materialize haskell.nix projects Materialization saves the part of the Nix expression which would be generated every time the project is built. This part tracks the package description and dependencies, so it only changes infrequently. Saving the output of this step (so that we can skip building it) makes the build faster. The drawback of this approach is that we must periodically run with checkMaterialization enabled to detect when the materialization needs to be updated. * Separate test and release workflows * Run release workflow only on push to master * Add nix/rematerialize.sh * Run Test workflow on pull requests only * Add a Stack step to Test workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In support of runtimeverification/k#1665.
All pull requests and push events will check that the materialization is up-to-date and push to the developer cache. The release job on the master branch will push the smaller dependency footprint to the user-facing cache.
An automatic workflow will update the materialized files on push events.
Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.