Skip to content

Include result.kore with --bug-report #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jan 15, 2021
Merged

Include result.kore with --bug-report #2324

merged 24 commits into from
Jan 15, 2021

Conversation

emarzion
Copy link
Contributor

Fixes #2018


Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@ttuegel ttuegel self-requested a review December 17, 2020 15:22
@ttuegel ttuegel changed the title copying result.kore Include result.kore with --bug-report Jan 5, 2021
@ttuegel ttuegel marked this pull request as ready for review January 5, 2021 11:42
& handle handleSomeException
& runKoreLog tmpDir koreLogOptions
e <- code tmpDir
for_ outputFileName $ flip copyFile (tmpDir </> "result.kore")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will only capture the output if it is being written to a file already. It will not capture the standard output. We should write the output to a temporary file first, and copy the file or print it to standard output afterward.

@ttuegel ttuegel self-requested a review January 12, 2021 20:56
@@ -594,21 +596,21 @@ mainWithOptions execOptions = do
("// Last configuration:\n" <> unparse lastConfiguration)
throwM someException

go :: Main ExitCode
go
go :: KoreExecOptions -> Main ExitCode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we are passing KoreExecOptions into this function now, can we extract it to the top level?

@ttuegel ttuegel self-requested a review January 13, 2021 15:14
@ttuegel ttuegel merged commit 978038e into master Jan 15, 2021
@ttuegel ttuegel deleted the include-result branch January 15, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include result.kore in --bug-report output
2 participants