-
Notifications
You must be signed in to change notification settings - Fork 44
Include result.kore with --bug-report #2324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kore/app/exec/Main.hs
Outdated
& handle handleSomeException | ||
& runKoreLog tmpDir koreLogOptions | ||
e <- code tmpDir | ||
for_ outputFileName $ flip copyFile (tmpDir </> "result.kore") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will only capture the output if it is being written to a file already. It will not capture the standard output. We should write the output to a temporary file first, and copy the file or print it to standard output afterward.
Co-authored-by: Thomas Tuegel <[email protected]>
Co-authored-by: Thomas Tuegel <[email protected]>
…nto include-result
kore/app/exec/Main.hs
Outdated
@@ -594,21 +596,21 @@ mainWithOptions execOptions = do | |||
("// Last configuration:\n" <> unparse lastConfiguration) | |||
throwM someException | |||
|
|||
go :: Main ExitCode | |||
go | |||
go :: KoreExecOptions -> Main ExitCode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we are passing KoreExecOptions
into this function now, can we extract it to the top level?
Fixes #2018
Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.