Skip to content

Remove the Target type from Kore.Equation #2344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Jan 25, 2021

Conversation

andreiburdusa
Copy link
Contributor

@andreiburdusa andreiburdusa commented Jan 11, 2021

As #2120 (comment) describes, but with an extra case for when swapping a pair produces a collision of keys.


Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@andreiburdusa andreiburdusa marked this pull request as ready for review January 14, 2021 19:33
@andreiburdusa andreiburdusa requested review from ttuegel and removed request for ttuegel January 14, 2021 19:34
@andreiburdusa andreiburdusa marked this pull request as draft January 15, 2021 10:50
@andreiburdusa andreiburdusa marked this pull request as ready for review January 15, 2021 16:16
@ttuegel ttuegel self-requested a review January 19, 2021 15:30
@andreiburdusa andreiburdusa requested a review from ttuegel January 19, 2021 20:08
Copy link
Contributor

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added more documentation, but I also (as reviewer) need to tend to a couple of clean-up item.s

@ttuegel ttuegel self-requested a review January 22, 2021 20:18
Copy link
Contributor

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some clean up and spent a few hours trying to catch what I thought must be a latent bug, before I finally convinced myself that the bug I imagined was impossible. I added a comment to explain my reasoning. @andreiburdusa Please review what I refactored. You can merge it when you are satisfied.

@andreiburdusa andreiburdusa merged commit 19f7475 into master Jan 25, 2021
@andreiburdusa andreiburdusa deleted the remove-Target-from-Equation branch January 25, 2021 16:22
@andreiburdusa andreiburdusa mentioned this pull request Mar 4, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants