-
Notifications
You must be signed in to change notification settings - Fork 44
Remove the Target type from Kore.Equation #2344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…in applyMatchResult
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added more documentation, but I also (as reviewer) need to tend to a couple of clean-up item.s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some clean up and spent a few hours trying to catch what I thought must be a latent bug, before I finally convinced myself that the bug I imagined was impossible. I added a comment to explain my reasoning. @andreiburdusa Please review what I refactored. You can merge it when you are satisfied.
As #2120 (comment) describes, but with an extra case for when swapping a pair produces a collision of keys.
Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.