Use unit and element symbol attributes #2365

MirceaS · 2021-01-25T14:56:17Z

This PR aims to get rid of the need to use MetadataTools in the process of internalization of builtin terms. The way this works is that symbols now have three additional attributes, each of which is optional. These attributes are, at the moment, only populated for symbols that are hooked to builtin symbols (such as set concatenation, map element etc.) and they point to that builtin's unit, element or concat symbols. The values for these attributes come from the attributes explicitly written in the definition kore files or from other trivial deductions (e.g. the map unit will set it's unit attribute to itself).
Before, we would only use the MetadataTools to get these symbols at internalization time from the Sort attributes in order to populate the resulting InternalAc, but with these changes, we no longer have to look at the Sort's attributes, being able to instead only look at attributes of the symbols that make up our builtin directly.
Additionally, since the three symbol fields of an InternalAc are mainly just used for unparsing, we can sometimes get away with only recording the id of a symbol, rather than the a full Symbol that also has attributes.

Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

MirceaS · 2021-02-10T21:30:19Z

kore/src/Kore/Builtin/AssocComm/AssocComm.hs

 -- | Wrapper for giving names to arguments.
-newtype UnitSymbol = UnitSymbol {getUnitSymbol :: Symbol}
+-- newtype UnitSymbol = UnitSymbol {getUnitSymbol :: Symbol}

 -- | Wrapper for giving names to arguments.
-newtype ConcatSymbol = ConcatSymbol {getConcatSymbol :: Symbol}
+-- newtype ConcatSymbol = ConcatSymbol {getConcatSymbol :: Symbol}


TODO: Remove these comments

ana-pantilie

Could you please add a description to the PR as well?

kore/src/Kore/Attribute/Concat.hs

kore/src/Kore/Attribute/Element.hs

kore/src/Kore/Attribute/Concat.hs

ana-pantilie · 2021-03-05T10:09:12Z

kore/src/Kore/Attribute/Concat.hs

+      | otherwise = error $
+        "Concat symbol mismatch error! Found both "
+        ++ unparseToString aSymbol
+        ++ " and "
+        ++ unparseToString bSymbol
+        ++ " inside term. This is a bug in the Haskell backend."


Would it be better to add an error log entry type for this? Also, we should probably format the message with Pretty.

I have an additional question. If this throws an error, are we 100% certain that this is a bug in the backend or is it possible that the frontend generated the attributes wrong?

To quickly answer your second question, it could be indeed that the frontend generated some bad attributes. I should probably change that message to just say "This is a bug." as it could be in either the frontend or backend.

ana-pantilie · 2021-03-05T10:15:33Z

kore/src/Kore/Attribute/Element.hs

+mergeElement a@(Element (Just aSymbol)) (Element (Just bSymbol))
+      | aSymbol == bSymbol = a
+      | otherwise = error $
+        "Element symbol mismatch error! Found both "
+        ++ unparseToString aSymbol
+        ++ " and "
+        ++ unparseToString bSymbol
+        ++ " inside term.  This is a bug in the Haskell backend."


Similar to my comment on mergeConcat.

kore/src/Kore/Builtin/AssociativeCommutative.hs

ana-pantilie · 2021-03-05T10:40:15Z

kore/src/Kore/Builtin/AssociativeCommutative.hs

@@ -260,6 +272,90 @@ instance TermWrapper NormalizedMap where

    simplifiedAttributeValue = TermLike.simplifiedAttribute . getMapValue

+
+toNormalizedInternalMap


Can you please document this and the rest of the functions you added to this file?

I just did, let me know if you're happy with it.

kore/src/Kore/Builtin/Map/Map.hs

kore/src/Kore/Builtin/Set/Set.hs

MirceaS · 2021-03-05T19:55:42Z

Could you please add a description to the PR as well?

How's this?

emarzion · 2021-03-08T07:13:58Z

test/regression-evm-semantics-39dd1e5/test-add0-tmp.in.GYhmR347rd

@@ -0,0 +1 @@
+LblinitGeneratedTopCell{}(Lbl'Unds'Map'Unds'{}(Lbl'Unds'Map'Unds'{}(Lbl'Unds'Map'Unds'{}(Lbl'Unds'Map'Unds'{}(Lbl'Stop'Map{}(),Lbl'UndsPipe'-'-GT-Unds'{}(inj{SortKConfigVar{}, SortKItem{}}(\dv{SortKConfigVar{}}("$SCHEDULE")),inj{SortSchedule{}, SortKItem{}}(LblDEFAULT'Unds'EVM{}()))),Lbl'UndsPipe'-'-GT-Unds'{}(inj{SortKConfigVar{}, SortKItem{}}(\dv{SortKConfigVar{}}("$MODE")),inj{SortMode{}, SortKItem{}}(LblVMTESTS{}()))),Lbl'UndsPipe'-'-GT-Unds'{}(inj{SortKConfigVar{}, SortKItem{}}(\dv{SortKConfigVar{}}("$CHAINID")),inj{SortInt{}, SortKItem{}}(\dv{SortInt{}}("1")))),Lbl'UndsPipe'-'-GT-Unds'{}(inj{SortKConfigVar{}, SortKItem{}}(\dv{SortKConfigVar{}}("$PGM")),inj{SortEthereumSimulation{}, SortKItem{}}(inj{SortJSON{}, SortEthereumSimulation{}}(LblJSONObject{}(LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("add0")),LblJSONObject{}(LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("_info")),LblJSONObject{}(LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("comment")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}(""))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("filledwith")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("testeth 1.5.0.dev2-52+commit.d419e0a2"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("lllcversion")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("Version: 0.4.26-develop.2018.9.19+commit.785cbf40.Linux.g++"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("source")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("src/VMTestsFiller/vmArithmeticTest/add0Filler.json"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("sourceHash")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("2d47e8f287f580e1e0ec6b926375f8fee1142475cbf3bdcdf9305e618b66cb40"))),Lbl'Stop'List'LBraQuot'JSONs'QuotRBraUnds'JSONs{}()))))))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("callcreates")),LblJSONList{}(Lbl'Stop'List'LBraQuot'JSONs'QuotRBraUnds'JSONs{}())),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("env")),LblJSONObject{}(LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("currentCoinbase")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x2adc25665018aa1fe0e6bc666dac8fc2697ff9ba"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("currentDifficulty")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x0100"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("currentGasLimit")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x0f4240"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("currentNumber")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x00"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("currentTimestamp")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x01"))),Lbl'Stop'List'LBraQuot'JSONs'QuotRBraUnds'JSONs{}()))))))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("exec")),LblJSONObject{}(LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("address")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x0f572e5295c57f15886f9b263e2f6d2d6c7b5ec6"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("caller")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0xcd1722f2947def4cf144679da39c4c32bdc35681"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("code")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff01600055"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("data")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("gas")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x0186a0"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("gasPrice")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x5af3107a4000"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("origin")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0xcd1722f2947def4cf144679da39c4c32bdc35681"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("value")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x0de0b6b3a7640000"))),Lbl'Stop'List'LBraQuot'JSONs'QuotRBraUnds'JSONs{}())))))))))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("gas")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x013874"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("logs")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("out")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("post")),LblJSONObject{}(LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("0x0f572e5295c57f15886f9b263e2f6d2d6c7b5ec6")),LblJSONObject{}(LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("balance")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x0de0b6b3a7640000"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("code")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff01600055"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("nonce")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x00"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("storage")),LblJSONObject{}(LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("0x00")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0xfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffe"))),Lbl'Stop'List'LBraQuot'JSONs'QuotRBraUnds'JSONs{}()))),Lbl'Stop'List'LBraQuot'JSONs'QuotRBraUnds'JSONs{}())))))),Lbl'Stop'List'LBraQuot'JSONs'QuotRBraUnds'JSONs{}()))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("pre")),LblJSONObject{}(LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("0x0f572e5295c57f15886f9b263e2f6d2d6c7b5ec6")),LblJSONObject{}(LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("balance")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x0de0b6b3a7640000"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("code")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff01600055"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("nonce")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x00"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("storage")),LblJSONObject{}(Lbl'Stop'List'LBraQuot'JSONs'QuotRBraUnds'JSONs{}())),Lbl'Stop'List'LBraQuot'JSONs'QuotRBraUnds'JSONs{}())))))),Lbl'Stop'List'LBraQuot'JSONs'QuotRBraUnds'JSONs{}()))),Lbl'Stop'List'LBraQuot'JSONs'QuotRBraUnds'JSONs{}()))))))))))),Lbl'Stop'List'LBraQuot'JSONs'QuotRBraUnds'JSONs{}())))))))


Is there an explanation for why some of these have file extensions other than .kore?

That is due to the frontend changing the naming of the files in the temporary run directory. There's a discussion about it in our #k channel if you're interested.

ana-pantilie

In addition to my comments from the meeting, I added a few more suggestions.

ana-pantilie · 2021-03-08T15:42:32Z

kore/test/Test/Kore/Builtin.hs

@@ -78,44 +89,50 @@ test_internalize =

    , internalizes  "unitMap"
        unitMap
-        (mkMap [])
+        (mkMap [] True False False)


I think these tests would be easier to read if instead of using Bool values we'd create some datatypes with more suggestive names.

I experimented with different data types but I think that my latest changes strike the best balance between readability and complexity/overhead. What I ended up doing was just to define some constants to be True and False and I'm using those constants in the tests instead of the naked bools. I hope this addresses your point.

kore/test/Test/Kore/Step/Simplification/InternalMap.hs

Co-authored-by: ana-pantilie <[email protected]>

ttuegel

@MirceaS Please fix the names of the attribute fields and update the glossary (#2457).

ttuegel · 2021-03-11T02:23:02Z

kore/src/Kore/Attribute/Symbol.hs

+    , unitHook      :: !(Unit SymbolOrAlias)
+    , elementHook   :: !(Element SymbolOrAlias)
+    , concatHook    :: !(Concat SymbolOrAlias)


These fields refer to symbols, not hooks. Furthermore, all of the other fields in this record are named for the type of the field, so these should be named unit, element, and concat.

ttuegel · 2021-03-11T02:23:42Z

kore/src/Kore/Attribute/Symbol.hs

+    , unitHook      :: !(Unit SymbolOrAlias)
+    , elementHook   :: !(Element SymbolOrAlias)
+    , concatHook    :: !(Concat SymbolOrAlias)
+    -- ^ The above three are only populated if the symbol is a concat


Why is the third field populated if the symbol is a concat symbol? Wouldn't it always refer to the symbol itself?

MirceaS and others added 8 commits January 19, 2021 05:06

moved Concat, Element and Unit symbol files

39dd06e

added AC symbol fields to Symbol

8f3e91e

code refactoring

2434170

integrated new functions

4430f49

added the strict pragma to modules newly introduced

236818f

Materialize Nix expressions

eceb816

updated unparsing function

6a4f982

fixed redundant import issue

d5979cb

ttuegel changed the title ~~2222~~ Use unit and element symbol attributes Jan 27, 2021

MirceaS and others added 6 commits February 1, 2021 13:46

fixed error messages

4eb41de

Merge branch 'master' into 2222

db86bc9

fixed unit tests and refactored some code

fce3629

Materialize Nix expressions

434c43d

Merge branch 'master' into 2222

848e247

Materialize Nix expressions

7146edf

MirceaS commented Feb 10, 2021

View reviewed changes

MirceaS added 4 commits February 12, 2021 20:05

refactoring and redefining of Eq/Ord instances

238d0ee

removed no longer relevant comments and refactored some code

9e213dc

fixed strictness issue

a32f065

added unit tests for unparsing failures

ff0a162

ttuegel added the blocked label Feb 18, 2021

MirceaS removed the blocked label Feb 22, 2021

MirceaS and others added 8 commits February 22, 2021 11:19

Merge branch 'master' into 2222

fb52f46

Materialize Nix expressions

1102c8e

Merge branch 'master' into 2222

3b9e2e9

regenerated regression tests

dd235cf

Materialize Nix expressions

2cd3a6f

Merge branch 'master' into 2222

07f289c

updated kore file for tiny test

c172528

updated integration test kore files

8735ce6

ttuegel requested review from emarzion and ana-pantilie March 2, 2021 15:18

MirceaS added 4 commits March 3, 2021 00:29

Merge branch 'master' into 2222

dde2fda

fixed small error

a8c8afe

regenerated regression files again

49ab3d6

removed test for issue 2095

26d0ca6

ana-pantilie suggested changes Mar 5, 2021

View reviewed changes

addressed some PR comments

e00d538

prettified error messages for unit, element and concat mismatch

b0141a4

emarzion reviewed Mar 8, 2021

View reviewed changes

ana-pantilie approved these changes Mar 8, 2021

View reviewed changes

emarzion approved these changes Mar 8, 2021

View reviewed changes

MirceaS and others added 6 commits March 8, 2021 17:58

added HasCallStack to the new partial functions and their callers

fb7dcaa

Update kore/test/Test/Kore/Step/Simplification/InternalMap.hs

b984cce

Co-authored-by: ana-pantilie <[email protected]>

made some test easier to read

5185c50

Merge branch 'master' into 2222

ec67cfd

Materialize Nix expressions

07b13b5

fixed merge issue

784f96f

MirceaS added the automerge label Mar 9, 2021

Merge branch 'master' into 2222

a56a1fe

rv-jenkins merged commit abf0292 into master Mar 9, 2021

rv-jenkins deleted the 2222 branch March 9, 2021 20:49

ttuegel reviewed Mar 11, 2021

View reviewed changes

MirceaS restored the 2222 branch March 11, 2021 17:17

MirceaS mentioned this pull request Mar 15, 2021

Revert PRs related to InternalAc, Unit, Element & Concat symbols changes #2463

Merged

4 tasks

		@@ -260,6 +272,90 @@ instance TermWrapper NormalizedMap where

		simplifiedAttributeValue = TermLike.simplifiedAttribute . getMapValue


		toNormalizedInternalMap

		@@ -0,0 +1 @@
		LblinitGeneratedTopCell{}(Lbl'Unds'Map'Unds'{}(Lbl'Unds'Map'Unds'{}(Lbl'Unds'Map'Unds'{}(Lbl'Unds'Map'Unds'{}(Lbl'Stop'Map{}(),Lbl'UndsPipe'-'-GT-Unds'{}(inj{SortKConfigVar{}, SortKItem{}}(\dv{SortKConfigVar{}}("$SCHEDULE")),inj{SortSchedule{}, SortKItem{}}(LblDEFAULT'Unds'EVM{}()))),Lbl'UndsPipe'-'-GT-Unds'{}(inj{SortKConfigVar{}, SortKItem{}}(\dv{SortKConfigVar{}}("$MODE")),inj{SortMode{}, SortKItem{}}(LblVMTESTS{}()))),Lbl'UndsPipe'-'-GT-Unds'{}(inj{SortKConfigVar{}, SortKItem{}}(\dv{SortKConfigVar{}}("$CHAINID")),inj{SortInt{}, SortKItem{}}(\dv{SortInt{}}("1")))),Lbl'UndsPipe'-'-GT-Unds'{}(inj{SortKConfigVar{}, SortKItem{}}(\dv{SortKConfigVar{}}("$PGM")),inj{SortEthereumSimulation{}, SortKItem{}}(inj{SortJSON{}, SortEthereumSimulation{}}(LblJSONObject{}(LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("add0")),LblJSONObject{}(LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("_info")),LblJSONObject{}(LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("comment")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}(""))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("filledwith")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("testeth 1.5.0.dev2-52+commit.d419e0a2"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("lllcversion")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("Version: 0.4.26-develop.2018.9.19+commit.785cbf40.Linux.g++"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("source")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("src/VMTestsFiller/vmArithmeticTest/add0Filler.json"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("sourceHash")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("2d47e8f287f580e1e0ec6b926375f8fee1142475cbf3bdcdf9305e618b66cb40"))),Lbl'Stop'List'LBraQuot'JSONs'QuotRBraUnds'JSONs{}()))))))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("callcreates")),LblJSONList{}(Lbl'Stop'List'LBraQuot'JSONs'QuotRBraUnds'JSONs{}())),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("env")),LblJSONObject{}(LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("currentCoinbase")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x2adc25665018aa1fe0e6bc666dac8fc2697ff9ba"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("currentDifficulty")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x0100"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("currentGasLimit")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x0f4240"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("currentNumber")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x00"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("currentTimestamp")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x01"))),Lbl'Stop'List'LBraQuot'JSONs'QuotRBraUnds'JSONs{}()))))))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("exec")),LblJSONObject{}(LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("address")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x0f572e5295c57f15886f9b263e2f6d2d6c7b5ec6"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("caller")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0xcd1722f2947def4cf144679da39c4c32bdc35681"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("code")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff01600055"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("data")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("gas")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x0186a0"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("gasPrice")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x5af3107a4000"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("origin")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0xcd1722f2947def4cf144679da39c4c32bdc35681"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("value")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x0de0b6b3a7640000"))),Lbl'Stop'List'LBraQuot'JSONs'QuotRBraUnds'JSONs{}())))))))))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("gas")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x013874"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("logs")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("out")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("post")),LblJSONObject{}(LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("0x0f572e5295c57f15886f9b263e2f6d2d6c7b5ec6")),LblJSONObject{}(LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("balance")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x0de0b6b3a7640000"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("code")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff01600055"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("nonce")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x00"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("storage")),LblJSONObject{}(LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("0x00")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0xfffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffe"))),Lbl'Stop'List'LBraQuot'JSONs'QuotRBraUnds'JSONs{}()))),Lbl'Stop'List'LBraQuot'JSONs'QuotRBraUnds'JSONs{}())))))),Lbl'Stop'List'LBraQuot'JSONs'QuotRBraUnds'JSONs{}()))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("pre")),LblJSONObject{}(LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("0x0f572e5295c57f15886f9b263e2f6d2d6c7b5ec6")),LblJSONObject{}(LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("balance")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x0de0b6b3a7640000"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("code")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff01600055"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("nonce")),inj{SortString{}, SortJSON{}}(\dv{SortString{}}("0x00"))),LblJSONs{}(LblJSONEntry{}(inj{SortString{}, SortJSONKey{}}(\dv{SortString{}}("storage")),LblJSONObject{}(Lbl'Stop'List'LBraQuot'JSONs'QuotRBraUnds'JSONs{}())),Lbl'Stop'List'LBraQuot'JSONs'QuotRBraUnds'JSONs{}())))))),Lbl'Stop'List'LBraQuot'JSONs'QuotRBraUnds'JSONs{}()))),Lbl'Stop'List'LBraQuot'JSONs'QuotRBraUnds'JSONs{}()))))))))))),Lbl'Stop'List'LBraQuot'JSONs'QuotRBraUnds'JSONs{}())))))))

Use unit and element symbol attributes #2365

Use unit and element symbol attributes #2365

Uh oh!

Conversation

MirceaS commented Jan 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ana-pantilie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

MirceaS commented Mar 5, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ana-pantilie left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ttuegel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MirceaS commented Jan 25, 2021 •

edited

Loading