-
Notifications
You must be signed in to change notification settings - Fork 44
Remove defined marker #2380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove defined marker #2380
Conversation
…ndition' into replacement-map-in-sidecondition
…ork/kore into replacement-map-in-sidecondition
Co-authored-by: Thomas Tuegel <[email protected]>
…to remove-defined-marker
@andreiburdusa @ttuegel Sorry, I realized I forgot to add a description to the PR. This made me notice that a few changes could be cleaned up a little and that I was missing some tests. I also fixed the conflicts with master. |
kore/test/Test/Kore/Builtin/Map.hs
Outdated
[ do | ||
(guard . not) (isDefinedPattern termKey) | ||
(guard . not) | ||
(SideCondition.isDefined SideCondition.top termKey) | ||
pure (makeCeilPredicate termKey) | ||
, do | ||
(guard . not) (isDefinedPattern termMap) | ||
(guard . not) | ||
(SideCondition.isDefined SideCondition.top termMap) | ||
pure (makeCeilPredicate termMap) | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's extract a helper function for these list elements.
Co-authored-by: Thomas Tuegel <[email protected]>
Co-authored-by: Thomas Tuegel <[email protected]>
Fixes #2351
TermLike.Defined
entirely, definedness assumptions and checks are replaced byassumeDefined
andisDefined
SideCondition
available:assumeDefined
andisDefined
to not ignore the values of mapsReview checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.