Skip to content

Remove defined marker #2380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 80 commits into from
Mar 12, 2021
Merged

Remove defined marker #2380

merged 80 commits into from
Mar 12, 2021

Conversation

ana-pantilie
Copy link
Contributor

@ana-pantilie ana-pantilie commented Feb 1, 2021

Fixes #2351

  • removes TermLike.Defined entirely, definedness assumptions and checks are replaced by assumeDefined and isDefined
  • makes the SideCondition available:
    • to the builtin evaluators
    • when matching
    • in the SMT translator/evaluator
  • fixes both assumeDefined and isDefined to not ignore the values of maps

Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

ana-pantilie and others added 30 commits December 7, 2020 19:00
…ndition' into replacement-map-in-sidecondition
…ork/kore into replacement-map-in-sidecondition
@ana-pantilie ana-pantilie marked this pull request as ready for review March 9, 2021 14:14
@ttuegel ttuegel requested review from ttuegel and andreiburdusa March 9, 2021 15:24
@ana-pantilie
Copy link
Contributor Author

@andreiburdusa @ttuegel Sorry, I realized I forgot to add a description to the PR. This made me notice that a few changes could be cleaned up a little and that I was missing some tests. I also fixed the conflicts with master.

Comment on lines 1441 to 1449
[ do
(guard . not) (isDefinedPattern termKey)
(guard . not)
(SideCondition.isDefined SideCondition.top termKey)
pure (makeCeilPredicate termKey)
, do
(guard . not) (isDefinedPattern termMap)
(guard . not)
(SideCondition.isDefined SideCondition.top termMap)
pure (makeCeilPredicate termMap)
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's extract a helper function for these list elements.

@ana-pantilie ana-pantilie requested a review from ttuegel March 11, 2021 10:19
@rv-jenkins rv-jenkins merged commit c35bfa5 into master Mar 12, 2021
@rv-jenkins rv-jenkins deleted the remove-defined-marker branch March 12, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Defined marker
4 participants