Skip to content

kore-repl: Print human-readable error messages #2441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 8, 2021

Conversation

andreiburdusa
Copy link
Contributor

Fixes #2423


Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@ttuegel ttuegel requested a review from ana-pantilie March 5, 2021 15:19
@@ -278,7 +279,7 @@ runRepl
catchEverything a =
Exception.handleAll $ \e -> liftIO $ do
putStrLn "Stepper evaluation errored."
print e
print (Pretty.prettyException e)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, but we should at least try logging the exceptions as is done here, but without re-throwing the exception.

@andreiburdusa andreiburdusa merged commit 904f532 into master Mar 8, 2021
@andreiburdusa andreiburdusa deleted the kore-repl--issue-#2423 branch March 8, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kore-repl: Print human-readable error messages
3 participants