Skip to content

Fix Strict performance #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 16, 2021
Merged

Fix Strict performance #2447

merged 16 commits into from
Mar 16, 2021

Conversation

ana-pantilie
Copy link
Contributor

@ana-pantilie ana-pantilie commented Mar 9, 2021

Fixes #2439

  • sum-to-n from regression-evm-... now takes ~36s compared to over 180s on master

Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@ttuegel ttuegel marked this pull request as ready for review March 10, 2021 15:14
@ttuegel ttuegel self-requested a review March 10, 2021 15:30
Copy link
Contributor

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we need to make every binding of a SideCondition.Representation lazy. Why doesn't it work to make the type itself lazy, like this? Otherwise, we must ensure that every binding of such type is strict.

@ana-pantilie ana-pantilie requested a review from ttuegel March 11, 2021 10:19
@ana-pantilie ana-pantilie requested a review from ttuegel March 16, 2021 10:26
@rv-jenkins rv-jenkins merged commit d136446 into master Mar 16, 2021
@rv-jenkins rv-jenkins deleted the fix-strict-performance branch March 16, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug performance with Strict
3 participants