-
Notifications
You must be signed in to change notification settings - Fork 44
Emit a warning when kore-exec exceeds the depth limit #2461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please give your pull request a title and summary following this advice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please write a unit test which captures the surprising behavior you found about exceeding the depth limit.
Use `hpack -f kore` to regenerate kore.cabal
Is there a way to check that a warning is emitted during execution? What surprised me was that we should emit the warning even when the execution would have been stuck anyway at the same step in the absence of the depth limit. |
Test the warning emitted by exec when the depth limit is exceeded by using a new MonadLog instance, called TestLog, that saves log entries in its state
…nto warnDepthLimitExceeded
Add a warning log entry for when the backend stops due to exceeding the depth limit
Fixes #2449
Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.