Skip to content

Emit a warning when kore-exec exceeds the depth limit #2461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 17, 2021

Conversation

andreiburdusa
Copy link
Contributor

@andreiburdusa andreiburdusa commented Mar 12, 2021

Add a warning log entry for when the backend stops due to exceeding the depth limit
Fixes #2449


Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@ttuegel ttuegel self-requested a review March 12, 2021 16:19
Copy link
Contributor

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give your pull request a title and summary following this advice.

@andreiburdusa andreiburdusa changed the title Warn depth limit exceeded Emit a warning when kore-exec exceeds the depth limit Mar 15, 2021
@andreiburdusa andreiburdusa requested a review from ttuegel March 15, 2021 09:39
Copy link
Contributor

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write a unit test which captures the surprising behavior you found about exceeding the depth limit.

@andreiburdusa
Copy link
Contributor Author

Please write a unit test which captures the surprising behavior you found about exceeding the depth limit.

Is there a way to check that a warning is emitted during execution? What surprised me was that we should emit the warning even when the execution would have been stuck anyway at the same step in the absence of the depth limit.

@andreiburdusa andreiburdusa requested a review from ttuegel March 16, 2021 19:38
@rv-jenkins rv-jenkins merged commit abf1477 into master Mar 17, 2021
@rv-jenkins rv-jenkins deleted the warnDepthLimitExceeded branch March 17, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

krun: Distinguish stuck states from exceeding depth limit
3 participants