Skip to content

Run integration tests with Nix #2492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 24, 2021
Merged

Run integration tests with Nix #2492

merged 6 commits into from
Mar 24, 2021

Conversation

ttuegel
Copy link
Contributor

@ttuegel ttuegel commented Mar 20, 2021

This pull request adds a test.nix expression for running the integration tests.

Note that the Makefile will no longer build the backend automatically before running the tests. This is necessary to allow running the tests with an out-of-tree build.


Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

ttuegel added 2 commits March 20, 2021 06:48
Automatically rebuilding the backend makes it impossible to test an out-of-tree
build with the Makefile.
@ttuegel ttuegel requested a review from andreiburdusa March 20, 2021 11:49
@rv-jenkins rv-jenkins merged commit 4fb7d68 into master Mar 24, 2021
@rv-jenkins rv-jenkins deleted the nix-test branch March 24, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants