Skip to content

Fix Ac Unification error and Add new integration test #2493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 26, 2021
Merged

Fix Ac Unification error and Add new integration test #2493

merged 12 commits into from
Mar 26, 2021

Conversation

MirceaS
Copy link
Contributor

@MirceaS MirceaS commented Mar 20, 2021

Fixes #2378


Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@MirceaS MirceaS marked this pull request as ready for review March 23, 2021 15:11
@MirceaS MirceaS requested review from ttuegel and emarzion March 24, 2021 14:09
@@ -499,10 +499,9 @@ internalize ::
TermLike variable ->
TermLike variable
internalize tools termLike
| fromMaybe False (isMapSort tools sort')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we just removing this check because it is redundant? Or is there another reason?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the check that I asked you about the other day, the one that Evan removed in his PR that I then had to revert. You suggested I leave it in even if it doesn't solve the Issue linked to this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that is not the check I thought you were removing. It is redundant, and I'm glad to be rid of it, but it doesn't have anything to do with this issue in particular.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, is it fine to leave it in this PR or should I open a new PR?

@MirceaS MirceaS removed the automerge label Mar 25, 2021
Copy link
Contributor

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the title of the pull request following these guidelines.

@@ -499,10 +499,9 @@ internalize ::
TermLike variable ->
TermLike variable
internalize tools termLike
| fromMaybe False (isMapSort tools sort')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that is not the check I thought you were removing. It is redundant, and I'm glad to be rid of it, but it doesn't have anything to do with this issue in particular.

@MirceaS MirceaS changed the title added new integration test and removed sort check on internalization Fix Ac Unification error and Add new integration test Mar 25, 2021
@ttuegel ttuegel self-requested a review March 26, 2021 14:02
@rv-jenkins rv-jenkins merged commit 6f5fe0b into master Mar 26, 2021
@rv-jenkins rv-jenkins deleted the 2378 branch March 26, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error unifying empty set with symbolic function applications
4 participants