-
Notifications
You must be signed in to change notification settings - Fork 44
Fix Ac Unification error and Add new integration test #2493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -499,10 +499,9 @@ internalize :: | |||
TermLike variable -> | |||
TermLike variable | |||
internalize tools termLike | |||
| fromMaybe False (isMapSort tools sort') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we just removing this check because it is redundant? Or is there another reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the check that I asked you about the other day, the one that Evan removed in his PR that I then had to revert. You suggested I leave it in even if it doesn't solve the Issue linked to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that is not the check I thought you were removing. It is redundant, and I'm glad to be rid of it, but it doesn't have anything to do with this issue in particular.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, is it fine to leave it in this PR or should I open a new PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the title of the pull request following these guidelines.
@@ -499,10 +499,9 @@ internalize :: | |||
TermLike variable -> | |||
TermLike variable | |||
internalize tools termLike | |||
| fromMaybe False (isMapSort tools sort') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that is not the check I thought you were removing. It is redundant, and I'm glad to be rid of it, but it doesn't have anything to do with this issue in particular.
Fixes #2378
Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.