Skip to content

Regression test script: do not delete golden files #2503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 26, 2021

Conversation

ana-pantilie
Copy link
Contributor

Fixes #2499


Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

else
mkdir $testdir
echo "include \$(CURDIR)/../include.mk" > $testdir/Makefile
echo "" >> $testdir/Makefile
echo "test-%.sh.out: \$(TEST_DIR)/test-%-*" >> $testdir/Makefile
# TODO: do we want to "make golden" here?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's OK to do nothing here. The tests will fail when the pull request is added.

@ana-pantilie ana-pantilie marked this pull request as ready for review March 26, 2021 14:56
@rv-jenkins rv-jenkins merged commit 31eefe1 into master Mar 26, 2021
@rv-jenkins rv-jenkins deleted the regenerate-script-preserve-golden branch March 26, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression test update script should preserve golden file
3 participants