SideCondition.toRepresentation: remove mapVariables #2510
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2476
Fixes #2485
There is a space leak related to
TermLike.traverseVariables
, and c35bfa5 increased the size of theSideCondition
and therefore the number of times this function is called.We discussed that the
mapVariables
call here is not entirely correct (because it erases theRewritingVariable
information) and that it's actually no longer necessary since the simplifier only uses one variable type now anyway.Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.