Skip to content

SideCondition.toRepresentation: remove mapVariables #2510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 29, 2021

Conversation

ana-pantilie
Copy link
Contributor

@ana-pantilie ana-pantilie commented Mar 29, 2021

Fixes #2476
Fixes #2485

There is a space leak related to TermLike.traverseVariables, and c35bfa5 increased the size of the SideCondition and therefore the number of times this function is called.

We discussed that the mapVariables call here is not entirely correct (because it erases the RewritingVariable information) and that it's actually no longer necessary since the simplifier only uses one variable type now anyway.


Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@ana-pantilie ana-pantilie marked this pull request as ready for review March 29, 2021 16:51
@ana-pantilie ana-pantilie requested a review from ttuegel March 29, 2021 16:53
@ttuegel ttuegel merged commit ec02c41 into master Mar 29, 2021
@ttuegel ttuegel deleted the sidecondition-map-variables branch March 29, 2021 19:47
@virgil-serbanuta
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increased memory usage in the repl Productivity dropped
3 participants