Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes manifest unknown error when running
./docker/build.sh
:Use the newer docker hub tag format by removing prefix "v" from k release version with
cut -c2-
in./docker/build.sh
. I also removed the old tag formattercut --delimiter="-" --field="2"
.Additionally, in the readme, specify
kore
as a make target in order to buildkore-exec
,kore-repl
, andkore-parser
which are all needed when running./docker/run.sh make test
. Previously,./docker/run.sh make
only builtkore-exec
.Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.