Skip to content

kore-repl: call warnIfLowProductivity before throwing ExitSuccess or ExitFailure #2581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 4, 2021

Conversation

andreiburdusa
Copy link
Contributor

@andreiburdusa andreiburdusa commented Apr 29, 2021

Needed for #2528


Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@andreiburdusa andreiburdusa changed the title Call warnIfLowProductivity before throwing ExitSuccess or ExitFailure kore-repl: call warnIfLowProductivity before throwing ExitSuccess or ExitFailure Apr 29, 2021
@andreiburdusa andreiburdusa marked this pull request as ready for review April 29, 2021 16:50
@ttuegel ttuegel self-requested a review May 4, 2021 14:28
@rv-jenkins rv-jenkins merged commit 486dfd5 into master May 4, 2021
@rv-jenkins rv-jenkins deleted the warnIfLowProductivity-success-failure branch May 4, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants