Skip to content

Cache the result of building an LLVM lib in run-with-tarball.sh #3807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 15, 2024

Conversation

goodlyrottenapple
Copy link
Contributor

@goodlyrottenapple goodlyrottenapple commented Apr 12, 2024

This change hashes the LLVM definition.kore file, extracted from a tarball and checks if we already have a compiled LLVM library cached from before. This is useful when re-running a full set of tarballs several times, but also speeds up things on a single run as many of the definitions within a set of tests are the same.

@goodlyrottenapple goodlyrottenapple marked this pull request as ready for review April 12, 2024 12:54
Copy link
Member

@jberthold jberthold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good idea!

Copy link
Contributor

@geo2a geo2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@goodlyrottenapple goodlyrottenapple merged commit a000386 into master Apr 15, 2024
@goodlyrottenapple goodlyrottenapple deleted the sam/run-with-tarball-cache-llvm-lib branch April 15, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants