Merge Match/Unify modules #3810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geo2a
approved these changes
Apr 15, 2024
Merged
goodlyrottenapple
added a commit
that referenced
this pull request
Apr 29, 2024
This is a followup to #3810 which: - removes the bidirectional matching code and `IsNotMatch` as the substitution produced by this code will always be a matching one - re-factor the list and map matching code adding comments describing the match cases in more detail --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Jost Berthold <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3785 by merging the two versions of our matching algorithm, one used in matching rewrite rules and another matching function/simplification rules. This is a first pass which mostly just merges the two algorithms, prserving most of the divergent behaviour under the
Rewrite/EvalMatchTypeflag. A followup refactor should clean up this code further.This PR is a port of runtimeverification/hs-backend-booster#573 where the development and testing happened.