Booster flag to disable simplification before fall-back request #3825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logs are showing that the simplification performed before fall-back execute requests is often not productive. This PR provides a server flag to switch it off and save the overhead. OTOH, the simplification may prune spurious branches, saving a `Branching` re-execution in `kore-rpc` in some cases. Therefore the default behaviour is still to simplify before fallback requests.
|
We had such a change (without flag control) last year and found problems in KEVM tests. |
geo2a
approved these changes
Apr 24, 2024
goodlyrottenapple
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs are showing that the simplification performed before fall-back execute requests is often not productive. This PR provides a server flag to switch it off and save the overhead.
OTOH, the simplification may prune spurious branches, saving a
Branchingre-execution inkore-rpcin some cases. Therefore the default behaviour is still to simplify before fallback requests.