-
Notifications
You must be signed in to change notification settings - Fork 44
One-line contextual logging of Kore actions #3837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
98d840f
to
5f25cf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, maybe for the next iteration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left one comment about making a single copy of showHashHex
. If the timings look ok with contextual logs turned off, I'm happy to merge
a3c06ca
to
bce8a4f
Compare
Kontrol performance with 10 workers. No visible performance degradation. Will re-run with 1 worker overnight to hopefully get an empty table.
|
Kontrol performance with 1 worker:
|
Co-authored-by: Jost Berthold <[email protected]>
Combines #3833 and #3831
in Kore, implement rendering of oneline logs prefixed with the context stack, in the spirit of Implement better booster logging #3826
add
--log-format <standard|oneline|json> (default:oneline)
tokore-rpc-booster
.-l Rewrite
and friends, use--log-format standard
, i.e.kore-rpc-booster --log-format standard -l Rewrite
--log-context
is passed, the log format is effectively override to beoneline
in
booster/tools/booster/Server.hs
, construct a log action to be passed to Kore. If no--log-context
options are passed, then the old-l RewriteKore
and fields levels still work with--log-format standard
. If--log-context
is passed, then the complete set of proxy-compatible Kore log entries is enabled, and the filtering is done using the glob context filter late in the colog pipeline.Things to do in a follow-up:
kore-rpc-booster --log-format json -l SimplifyJson
, which is not ideal. We need to remove-l SimplifyJson
and forward the log format to Booster instead.SimplifyJson
level and instead render the regular log items as json.