Skip to content

Fix collections internalisation #3841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 2, 2024
Merged

Fix collections internalisation #3841

merged 4 commits into from
May 2, 2024

Conversation

goodlyrottenapple
Copy link
Contributor

Fix pattern synonyms to store e.g. {...REST} as just REST

@goodlyrottenapple
Copy link
Contributor Author

KEVM

Test feature time master-602850806 time (feature/master-602850806) time
kontrol/test-expectcalltest-testexpectstaticcall-0-spec.k 49.88 55.98 0.8910325116112898
kontrol/test-expectreverttest-test_expectrevert_bytes4-0-spec.k 94.87 88.49 1.0720985422081593
TOTAL 144.75 144.47 1.0019381186405483

jberthold
jberthold approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@jberthold jberthold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good catch

@jberthold
Copy link
Member

Maybe add a few tests to Test.Booster.Pattern.InternalCollections?

@jberthold jberthold mentioned this pull request May 2, 2024
Merged
@goodlyrottenapple goodlyrottenapple marked this pull request as ready for review May 2, 2024 08:51
@goodlyrottenapple goodlyrottenapple merged commit 8a9161b into master May 2, 2024
@goodlyrottenapple goodlyrottenapple deleted the sam/collections-internalisation-fix branch May 2, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jberthold jberthold jberthold approved these changes

@geo2a geo2a geo2a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goodlyrottenapple @jberthold @geo2a