-
Notifications
You must be signed in to change notification settings - Fork 44
Allow kore-rpc-booster to read additional options from KORE_RPC_OPTS #3842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rv-jenkins
merged 4 commits into
master
from
HOTFIX-allow-kore-rpc-booster-args-in-env-var
May 2, 2024
Merged
Allow kore-rpc-booster to read additional options from KORE_RPC_OPTS #3842
rv-jenkins
merged 4 commits into
master
from
HOTFIX-allow-kore-rpc-booster-args-in-env-var
May 2, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…variable * like `kore-rpc` , `kore-rpc-booster` should read additional options from an environment variable. * This PR chooses the same variable name as for `kore-rpc` for consistency and to avoid it getting too long.
1d164a9
to
c90d2cc
Compare
I ran a KEVM performance test using
|
goodlyrottenapple
approved these changes
May 2, 2024
geo2a
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kore-rpc
,kore-rpc-booster
should read additional options from an environment variable.kore-rpc
for consistency and to avoid it getting too long.Use case: testing optional optimisation in performance tests without having to modify the pytest framework or the
KoreServer
inpyk