Add details to evaluation aborts that cause warnings #3851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For warnings during evaluation/simplification, the warning message advises users to use a certain log context. This PR changes the recommended log context to `*abort*detail`, for which informative details have been added in all call sites of `logWarn`. At the same time, the warning about too many iterations was duplicated in the `Rewrite` module, and was therefore downgraded to `Simplify` level there.
goodlyrottenapple
approved these changes
May 7, 2024
geo2a
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For warnings during evaluation/simplification, the warning message advises users to use a certain log context. This PR changes the recommended log context to
*abort*detail, for which informative details have been added in all call sites oflogWarn.At the same time, the warning about too many iterations was duplicated in the
Rewritemodule, and was therefore downgraded toSimplifylevel there.Fixes #3849