Fix some small problems #3878
Merged
Fix some small problems #3878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jberthold
commented
May 20, 2024
| (Just forceDepth, _) -> Just forceDepth | ||
| (_, Just maxDepth) -> Just $ maxDepth - currentDepth | ||
| _ -> Nothing | ||
| (bResult, bTime) <- Stats.timed $ booster (Execute r{maxDepth = mbDepthLimit}) | ||
| case bResult of | ||
| Right (Execute boosterResult) | ||
| -- the execution reached the depth bound due to a forced Kore simplification | ||
| | boosterResult.reason == DepthBound && isJust cfg.forceFallback -> do |
There was a problem hiding this comment.
Once cDepth was reaching maxDepth (see above, when maxDepth < forceDepth) we were starting to make requests with max-depth: 0 and looping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--interim-simplificationproblem: WhenmaxDepth < forceFallback, the proxy was considering a genuineDepthBoundresult as an artefact caused by the interim simplification, and would try to continue execution.cabal.projectfile was set up to never profile anyboosterorkore-rpc-typescodeRpcClientreported a server connection error and retried (the criterion for recognising connection errors was to general).