-
Notifications
You must be signed in to change notification settings - Fork 44
Retry SMT queries in Booster when deciding predicates #3889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6390939
to
005e42a
Compare
458bbfc
to
d9f1318
Compare
aaaa4c1
to
b22c9f8
Compare
No difference in KEVM performance:
|
This reverts commit 3f17f82.
The |
goodlyrottenapple
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Left some minor comments
jberthold
approved these changes
Jun 4, 2024
booster/test/rpc-integration/test-non-linear-int-requires/response-init.json
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3884
refactor the SMT modules to allow re-initializing the solver dynamically:
SMTContext
now carries the prelude andSMTOptions
closeContext
function only closes the solver handle, and does not close the solver transcript handle. The newdestroyContext
function does both.SMT
monad is is changed to haveStateT SMTContext
. TheBooster.SMT.Interface.restartSolver
function restarts the solver with modified options, altering the context. Note that it does not touch the transcript handle, i.e. it will persist the sovler restarts.the
getModelFor
andcheckPredicates
functions now have logic to retry with doubled timeout when the solver returns unknown.I'm checking-in the integration test that I was using when developing. I ran the server with
--smt-timeout 1
to observe the retry mechanism kicking-in, but I do not think it is a good idea to try to force it to retry the queries in CI. The test may still be useful when working on the SMT code in future.